Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SF6: catch SessionNotFoundException #595

Merged
merged 1 commit into from
Aug 3, 2023
Merged

SF6: catch SessionNotFoundException #595

merged 1 commit into from
Aug 3, 2023

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Aug 3, 2023

Since SF6 getSession is throwing, rather than a nullable (but i kept it for BC)

This handles it.

We noticed Session not found error on http://, since this listener runs before redirecting to https://

dbu
dbu approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks a lot! and yes until we drop support for older versions, we need to still check for null.

@dbu dbu merged commit 10708bf into FriendsOfSymfony:2.x Aug 3, 2023
10 checks passed
@dbu
Copy link
Contributor

dbu commented Aug 3, 2023

https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/releases/tag/2.16.2

@ro0NL
Copy link
Contributor Author

ro0NL commented Aug 3, 2023

fastest release ever 🚀 💯

@ro0NL ro0NL deleted the ro0NL-patch-1 branch August 3, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ro0NL @dbu