Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reencoded sound effects #54

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Reencoded sound effects #54

merged 2 commits into from
Aug 23, 2022

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Aug 23, 2022

These are music tracks reencoded to the parameters in github action;
VBR quality 3
48kHz sampling rate
Up to 1 channel (mono)
Up to 128kbps bit rate

Also adjusts tests for correct "less or equals" test for bitrate

@irwiss irwiss marked this pull request as ready for review August 23, 2022 16:31
@Fris0uman
Copy link
Owner

Why are there a few files showing as +100% size?

@irwiss
Copy link
Contributor Author

irwiss commented Aug 23, 2022

I'm not sure actually, could be github UI bug, if you click the ... menu and then view file
image
You'll arrive at the file page and it shows that it's 5.37Kb (if you download it'll be 5496 bytes, old filesize 5,490 bytes), so the +/-bytes count is correct but the % is calculated weird

May be it's % of the file contents unchanged? i'm not sure how it makes sense for binary files though

@irwiss
Copy link
Contributor Author

irwiss commented Aug 23, 2022

image
Used some online binary diff tool - besides the obvious codec string change there's about half the file changed ~3k bytes, really not sure what github calculates for the percentage

@Fris0uman Fris0uman merged commit 90fa166 into Fris0uman:main Aug 23, 2022
@irwiss irwiss deleted the reencoded-sfx branch August 23, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants