-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix random Timer too close or Move queue overflow errors #123
Conversation
Reviewer's Guide by SourceryThis pull request addresses issues with random 'Timer too close' and 'Move queue overflow' errors by modifying the ShakeTuneProcess to include a reactor for better timeout handling and process priority adjustments. Additionally, it introduces multiprocessing for file writing in the Accelerometer class and ensures all file writes complete before proceeding in various command methods. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Frix-x - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 7 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Summary by Sourcery
This pull request addresses random 'Timer too close' and 'Move queue overflow' errors by adjusting process priority and improving timeout handling. It also enhances the reliability of file writing operations by introducing a queue and separate processes for writing accelerometer data, ensuring all file writes are completed before proceeding.