remove usage of homing_positive_dir
#290
Conversation
As stated in Klipper docs: "It is better to use the default than to specify this parameter. The default is true if `position_endstop` is near `position_max` and false if near `position_min`."
There was a problem hiding this comment.
Thanks for this PR.
I agree that hardcoding the homing dir is not necessary anymore today. If I remember correctly, it was a mandatory parameter a couple of year ago but now that there is an automatic direction extrapolation from the endstop position, I agree that it could lead to dangerous behaviors. Let's remove this :)
However, as stated in the next comment, using the computed value is still necessary for the Zhop after homing the Z axis. I'm using the "settings" value and not the "config" value. So this should work even if there is nothing specified in the config.
|
Yeah the check is not necessary as this parameter is populated automatically by Klipper and it's this value that we retrieve (not the one from the config). Thanks, I'll merge for the next version :) |
As stated in Klipper docs: "It is better to use the default than to specify this parameter. The default is true if
position_endstopis nearposition_maxand false if nearposition_min."Including this parameter seems to be at best redundant and at worst potentially damaging for printers that home at axis minimum.