-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ubuntu install script + general-ish .config&patching script #26
Conversation
This is done to be able to change the $_where in the non-Arch install script
…u" as option Show options that won't apply when target distro is Ubuntu
The script downloads linux's source code, applies patches, and handles the .config file after copying the one from the distribution it's running on. TODO: Implement install (and maybe uninstall)
Speaking of
If I save then quit, without doing any modifications, the generated fragments are the following:
I am not sure this is related with my script, but I am writing it if ever it's the case. |
@Tk-Glitch Can the function |
Due to health issues I won't be able to properly review your code until a few more days. Sorry about that. |
Got it! I will move it then.
Don't you even worry, I will keep on working on the script meanwhile, I hope it's nothing serious. get better soon ! 😄 |
With the latest sub-versions of linux-5.7, 5.7.6 and 5.7.7 so far (5.7.5 works) I have been getting these errors, they happen when the
Any idea what the reason behind this can be ? |
For now it won't apply for Arch, but can be implemented
This approach has the least impact on the hard-drive given that only the files that need to be changed get changed by git.
Given that I am having problems with the latest kernel sub-versions, I have found a very elegant way to switch between sub-versions and to reset the sources to their original state when re-running the install script : by using git ! I found a branch,
What I win with this approach is that the hard drive is not over-used when resetting sources to their original state when re-running the install script. Because, for resetting, I was doing I don't know if this same approach can be implemented for |
I'll review soon. |
linux57-tkg/customization.cfg
Outdated
@@ -77,9 +79,6 @@ _ftracedisable="false" | |||
# Set to "true" to disable NUMA, lowering overhead, but breaking CUDA/NvEnc on Nvidia equipped systems - Kernel default is "false" | |||
_numadisable="false" | |||
|
|||
# Set to "true" to enable misc additions - May contain temporary fixes pending upstream or changes that can break on non-Arch - Kernel default is "true" | |||
_misc_adds="true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is here to stay, even if I end up removing the specific patch it was initially introduced for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I wanted to discuss that with you. As I understand now you didn't put it only for Ubuntu to be able to compile, then okay!
Are you the one who reverts commits or me ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it was to have a place to add temporary patches without using -base for it. The decoupling of "that patch" with -base was following that logic of temporary fixing the issue we had with it.
I have no power on the PR's code until it's effectively merged afaik.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually gave you push permissions, with the "Allow edits by maintainers " 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a small concern about the misc patch, I would like people from ubuntu for example to get the amdgpu patch but not have the change that gives the leaky tty :/
patch -Np1 -i ../0003-glitched-cfs.patch | ||
msg2 "Applying Glitched CFS patch" | ||
patch -Np1 -i "$_where"/0003-glitched-cfs.patch | ||
msg2 "Done" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced by those "Done" messages. Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was debugging in the beginning, and I wanted to know which lines are terminating properly. If you don't like the "Done" let's get rid of it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't actually ran the script to see the output yet, but with the patch coming after outputting it's "header message" I gave you my initial thoughts about it. I'm not against them if you consider they are helping out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find them useful and like to see that something is "Done" before it moves to something else. The final decision is up to you, it will take me few seconds to remove all the "Done" messages.
Now that Linux 5.8 is out, I will add the install.sh there too. |
I'm merging the 5.7 version and will work on making it a bit more flexible. |
Untested on buntu. Following #26
Awesome! Will you make the script for 5.8 or do you want me to do it ? |
I'll reflect the changes to 5.8, no worries. The small tweaks I have made in the commit above should be all good on buntu but I haven't tested them there, so I might have missed a quirk or two. Do you happen to have checked that I didn't break anything by any chance ? 😄 |
Cool! I haven't tested the Ubuntu build with your changes, will do now. Also can you remove all occurrences of |
Sorry, another thing, in |
Okay it works! I got bamboozled by the |
> Update TkgThingy > linux-tkg: linux58-tkg: 5.8.2 > linux-tkg: linux57-tkg: 5.7.16 > linux-tkg: linux54-tkg: 5.4.59 > linux-tkg: linux59-rc-tkg: Update readme and comment out some disabled options in .cfg > linux-tkg: linux-tkg: Explicitly set X86_P6_NOP default (disabled) so it doesn't prompt on archs not selecting it. > linux-tkg: linux58-tkg: Update prjc / BMQ patchset to v5.8-r1 > linux-tkg: linux-tkg: non-Arch: Set _misc_adds="false" for now > linux-tkg: linux-tkg: The double equal sign amusement continuation > linux-tkg: Introduce initial linux59-rc-tkg > linux-tkg: linux58-tkg: Update readme > linux-tkg: linux58-tkg: Bring Ubuntu install script and related changes initially introduced with Frogging-Family/linux-tkg#26 > nvidia-all: Add initial kernel 5.9 patch, based on Isaak I. Aleksandrov's > nvidia-all: 450.66 > wine-tkg-git: Hotfixer: Update rules and custom patches for 8f3bd63b, staging 7d08bb86 and fs hack unbreak list for 2b484b1a > wine-tkg-git: Proton-tkg: makepkg: Write "true" versioning string to the version file > wine-tkg-git: Hotfixer: Remove undesired winevulkan_vkGetPhysicalDeviceSurfaceCapabilitiesKHR restoration from 01150d7f hotfixes 64/65/66. > wine-tkg-git: Hotfixer: Early: Legacy: Fix the mfplat patchset typo in v5.15 release (fixed in v5.15.1) > wine-tkg-git: Use a triple-way selector for custom compiler paths
Hello!
This is my current work after opening the issue #21. The implemented changes so far are the following :
_distro
incustomization.cfg
where the user should put "Arch", "Ubuntu" or "Fedora". This options is used for two reasons:install.sh
to know which distro it's working on, it will be important when installing since Fedora and Ubuntu are different_tkg_srcprep()
that isn't useful for non-arch installs./etc/os-release
, where theNAME
variable contains the distro's name. Sounds rather appealing to me, but I didn't want to bother for now. What do you think of it ? That would make the option_distro
useless. But would mean that Arch derivatives, Debian derivatives and Redhat derivatives should be recognized appropriately.install.sh
script, for now it only downloads the linux kernel sources, patches them, and does the config starting off the distro's current one._tkg_srcprep()
a bit more verbose, just so I can visually see when a patch starts and when it ends. Up to you if you want to keep it.make xconfig
option.I will work on the Ubuntu install and uninstall process. I will base it off a custom name, given by the user, the recognize the
deb
packages installed by the script and uninstall them. After that, I will tackle Fedora.Also, please check that I haven't broken the PKGBUILD process.
Tell me what you think, I will keep you updated.