Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent flyout content overflow #2010

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

jose-costa-frontify
Copy link
Contributor

@jose-costa-frontify jose-costa-frontify commented Aug 15, 2024

CU-8695ebaxj

I noticed one of the uses of this component in the web app has its own overflow prevention script which means this component also suffers from this issue. To fix it, I applied the same fix as we have for Dropdown and Select.

@jose-costa-frontify jose-costa-frontify requested a review from a team as a code owner August 15, 2024 13:42
Copy link

changeset-bot bot commented Aug 15, 2024

🦋 Changeset detected

Latest commit: 7f43c29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@frontify/fondue-components Patch
@frontify/fondue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 15, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-26 09:26 UTC

@frontify-clickup-bot
Copy link
Collaborator

@jose-costa-frontify jose-costa-frontify merged commit 8172ebf into main Aug 26, 2024
15 of 16 checks passed
@jose-costa-frontify jose-costa-frontify deleted the fix/add-flyout-max-height branch August 26, 2024 09:26
Copy link
Contributor

Lead time: 10 days, 19 hours, 46 minutes, 15 seconds (259.77 total hours) from first commit to close.
Review time: 10 days, 19 hours, 43 minutes, 34 seconds (259.73 total hours) from ready for review to close.

  • First commit: 15.8.2024, 15:39:53.
  • Ready for review: 15.8.2024, 15:42:34.
  • Closed: 26.8.2024, 11:26:08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants