Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add workflow for generating icons #2067

Merged
merged 5 commits into from
Sep 19, 2024
Merged

feat: add workflow for generating icons #2067

merged 5 commits into from
Sep 19, 2024
+71 −0

Conversation

noahwaldner
Copy link
Contributor

No description provided.

@noahwaldner noahwaldner requested a review from a team as a code owner September 19, 2024 10:15
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8f90e03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-19 12:52 UTC

SamuelAlev
SamuelAlev reviewed Sep 19, 2024
View reviewed changes
.github/workflows/icon-generation.yaml Outdated Show resolved Hide resolved
.github/workflows/icon-generation.yaml Outdated Show resolved Hide resolved
noahwaldner and others added 3 commits September 19, 2024 14:41
@noahwaldner @SamuelAlev
Update .github/workflows/icon-generation.yaml
9e8b99d 
Co-authored-by: Samuel Alev <samuel.alev@frontify.com>
@noahwaldner @SamuelAlev
Update .github/workflows/icon-generation.yaml
141f957 
Co-authored-by: Samuel Alev <samuel.alev@frontify.com>
@noahwaldner
Merge branch 'main' into feat/generate-icons
8f90e03
@noahwaldner noahwaldner merged commit 644e380 into main Sep 19, 2024
3 checks passed
@noahwaldner noahwaldner deleted the feat/generate-icons branch September 19, 2024 12:52
@github-actions GitHub Actions
Copy link
Contributor

Lead time: 2 hours, 37 minutes, 56 seconds (2.63 total hours) from first commit to close.
Review time: 2 hours, 37 minutes, 16 seconds (2.62 total hours) from ready for review to close.

  • First commit: 19.9.2024, 12:14:38.
  • Ready for review: 19.9.2024, 12:15:18.
  • Closed: 19.9.2024, 14:52:34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelAlev SamuelAlev SamuelAlev left review comments

@jose-costa-frontify jose-costa-frontify jose-costa-frontify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noahwaldner @SamuelAlev @jose-costa-frontify