Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITV UK Audio Muting Support #384

Closed
ahkelly opened this issue Feb 18, 2022 · 6 comments
Closed

ITV UK Audio Muting Support #384

ahkelly opened this issue Feb 18, 2022 · 6 comments
Labels
Enhancement New feature or request

Comments

@ahkelly
Copy link

ahkelly commented Feb 18, 2022

I would like to open the conversation relating to audio muting of ITV UK. Unfortunately following the normal directions I cannot find the subtitles in the elements.

itv-find-no-results

Following 3. Video TextTrack Mode it does actually return the subtitles and below are the results. Hoping you can give some further guidance on what else I can try to get you the actual elements

itv-text-to-find

@ahkelly ahkelly added the Enhancement New feature or request label Feb 18, 2022
@richardfrost
Copy link
Collaborator

It looks like this site is using the Video TextTrack based on what you discovered, so there aren't traditional elements to filter like the other sites.

Did you try to test the possible config output by the script you ran? (bottom of last screenshot). If you'd like to keep the other sites active as well, you can do so like this:

{
  "www.channel4.com": [
    {
      "displaySelector": "div.subtitles-container",
      "mode": "elementChild",
      "parentSelector": "div.subtitles-container",
      "tagName": "SPAN"
    }
  ],

  "www.itv.com": [
    {
      "mode": "cue",
      "language": "en"
    }
  ]
}

@ahkelly
Copy link
Author

ahkelly commented Feb 18, 2022

Actually as I saw this same result suggestion on each of the uk sites using that script I assumed it was the default when no specific/better option was available. I did try it initially, without luck. I may have forgotten to refresh the browser, which needs to be done for the changes to take effect.

Now that I tried it again, using exact json above, just briefly this afternoon (after a page refresh), it seems to be working. I'll let you know more once I have more of a chance to test. However as of now, the filtering of the subtitle works, the audio is muting and when I have captions hidden that is also working without any display hiccups.

@richardfrost
Copy link
Collaborator

richardfrost commented Feb 18, 2022

That's great! I just noticed that script was a little out of date, so I've updated it on the page. For the rule, you'd really want it to be videoCueLanguage instead of language, like this:

{
  "www.itv.com": [
    {
      "mode": "cue",
      "videoCueLanguage": "en"
    }
  ]
}

@ahkelly
Copy link
Author

ahkelly commented Feb 19, 2022

I am yet to have any issues with this, all is working great.

@richardfrost
Copy link
Collaborator

That is awesome news! I'll make sure to get it added in the next version. Thanks for all your help in supporting these. Feel free to suggest another if one comes up.

@richardfrost
Copy link
Collaborator

I just submitted version 2.32.2 which now includes this config. You should be able to remove it from the custom sites if you'd like. I generally recommend using the rules included with the filter, just in case an update happens to the rule or the filter itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants