Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-stream): add nkey auth #32

Merged
merged 2 commits into from
Jun 27, 2024
Merged

feat(data-stream): add nkey auth #32

merged 2 commits into from
Jun 27, 2024

Conversation

lostman
Copy link
Contributor

@lostman lostman commented Jun 24, 2024

No description provided.

@lostman lostman marked this pull request as ready for review June 25, 2024 12:35
Copy link
Member

@Jurshsmith Jurshsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 . Could you please update the env.sample file with the new NATS_NKEY variable?

@lostman
Copy link
Contributor Author

lostman commented Jun 26, 2024

Looks good 👍 . Could you please update the env.sample file with the new NATS_NKEY variable?

There's no default nkey. What should I put there?

@Jurshsmith
Copy link
Member

There's no default nkey. What should I put there?

An empty string or garbage value works

@pedronauck pedronauck merged commit f29a514 into main Jun 27, 2024
4 checks passed
@pedronauck pedronauck deleted the nkey-conf branch June 27, 2024 18:11
pedronauck added a commit that referenced this pull request Aug 16, 2024
Co-authored-by: Pedro Nauck <pedronauck@gmail.com>
pedronauck added a commit that referenced this pull request Aug 16, 2024
Co-authored-by: Pedro Nauck <pedronauck@gmail.com>
pedronauck added a commit that referenced this pull request Aug 16, 2024
Co-authored-by: Pedro Nauck <pedronauck@gmail.com>
@Jurshsmith Jurshsmith self-assigned this Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants