Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit assets per address #47

Merged
merged 16 commits into from
Dec 17, 2023
Merged

Limit assets per address #47

merged 16 commits into from
Dec 17, 2023

Conversation

MujkicA
Copy link
Contributor

@MujkicA MujkicA commented Nov 27, 2023

Closes #46

@MujkicA MujkicA marked this pull request as ready for review November 28, 2023 17:13
@MujkicA MujkicA requested review from xgreenx, Voxelot and luizstacio and removed request for xgreenx November 29, 2023 10:29
src/routes.rs Outdated Show resolved Hide resolved
src/routes.rs Outdated Show resolved Hide resolved
src/routes.rs Outdated Show resolved Hide resolved
src/routes.rs Outdated Show resolved Hide resolved
src/routes.rs Outdated Show resolved Hide resolved
@MujkicA MujkicA requested a review from xgreenx November 29, 2023 21:55
tests/dispense.rs Show resolved Hide resolved
src/dispense_tracker.rs Show resolved Hide resolved
src/routes.rs Outdated Show resolved Hide resolved
tests/dispense.rs Show resolved Hide resolved
tests/dispense.rs Outdated Show resolved Hide resolved
tests/dispense.rs Outdated Show resolved Hide resolved
src/routes.rs Show resolved Hide resolved
src/routes.rs Outdated Show resolved Hide resolved
src/dispense_tracker.rs Show resolved Hide resolved
@xgreenx xgreenx mentioned this pull request Dec 10, 2023
tests/dispense.rs Outdated Show resolved Hide resolved
Co-authored-by: Brandon Vrooman <brandon.vrooman@gmail.com>
bvrooman
bvrooman previously approved these changes Dec 12, 2023
src/routes.rs Outdated Show resolved Hide resolved
@MujkicA MujkicA requested a review from xgreenx December 14, 2023 11:48
src/routes.rs Outdated
Comment on lines 196 to 200
dispense_tracker
.lock()
.unwrap()
.remove_in_progress(&address);
error(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant we need to call remove_in_progress on any error. You can move calling of the remove_in_progress into error function, then you should cover all cases=)

@xgreenx xgreenx merged commit 41b0c23 into master Dec 17, 2023
8 checks passed
@xgreenx xgreenx deleted the feature/limitation branch December 17, 2023 19:56
@Voxelot
Copy link
Member

Voxelot commented Dec 18, 2023

cc @FuelLabs/infra we'll need to make the newly introduced env var DISPENSE_LIMIT_INTERVAL configurable via helm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add limitation per address with one day timeout
4 participants