feat: Add --export to account to export account's private key #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchmindtree
previously approved these changes
Sep 7, 2022
| @@ -44,6 +44,9 @@ enum Command { | |||
| /// Get the address of an acccount from account index | |||
| Account { | |||
| account_index: usize, | |||
| #[clap(long)] | |||
| export: bool, | |||
There was a problem hiding this comment.
Perhaps we should have a separate command for this, just like we do for import? If so, we should also ensure the command is well documented.
Happy to approve for now so that it's at least possible to export in the meantime 👍
mitchmindtree
approved these changes
Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #39.
This PR adds
--exporttoforc-wallet accountso that people can get their private key from their accounts managed byforc-walletand use import and use them in SDKs. To not leak any private key in the terminal history it is shown in an alternate screen just like the seed phrase.