Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some comments #1720

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# This is a configuration file for the cargo plugin `cargo-make`. We use this plugin because of it's handling around
# cargo workspaces. Specifically, each task is run on workspace members indepedently, avoiding potential issues that
# arise from feature unification (https://doc.rust-lang.org/cargo/reference/features.html#feature-unification).
# Feature unification allows two unrelated crates with the same depedency to enable features on eachother.
# Feature unification allows two unrelated crates with the same dependency to enable features on eachother.
# This is problematic when a crate is built independently (when publishing / being consumed from crates.io),
# and it implicitly depended on features enabled by other crates in the same workspace.
# While feature resolver v2 attempted to resolve this problem, it still comes up in certain scenarios.
Expand Down
2 changes: 1 addition & 1 deletion crates/fuel-core/src/graphql_api/api_service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ impl RunnableTask for Task {
}
}

// Need a seperate Data Object for each Query endpoint, cannot be avoided
// Need a separate Data Object for each Query endpoint, cannot be avoided
#[allow(clippy::too_many_arguments)]
pub fn new_service<OnChain, OffChain>(
config: Config,
Expand Down
2 changes: 1 addition & 1 deletion crates/services/p2p/src/p2p_service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1451,7 +1451,7 @@ mod tests {

// Node B received the correct message
// If we try to publish it again we will get `PublishError::Duplicate`
// This asserts that our MessageId calculation is consistant irrespective of which Peer sends it
// This asserts that our MessageId calculation is consistent irrespective of which Peer sends it
let broadcast_request = broadcast_request.clone();
matches!(node_b.publish_message(broadcast_request), Err(PublishError::Duplicate));

Expand Down
2 changes: 1 addition & 1 deletion crates/services/p2p/src/peer_report.rs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ pub enum PeerReportEvent {
// `Behaviour` that reports events about peers
pub struct Behaviour {
pending_events: VecDeque<PeerReportEvent>,
// regulary checks if reserved nodes are connected
// regularly checks if reserved nodes are connected
health_check: Interval,
decay_interval: Interval,
}
Expand Down
2 changes: 1 addition & 1 deletion crates/types/src/services/txpool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ pub enum TransactionStatus {
/// Why this happened
reason: String,
},
/// Transaction was included in a block, but the exection was reverted
/// Transaction was included in a block, but the execution was reverted
Failed {
/// Included in this block
block_height: BlockHeight,
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/tx.rs
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ async fn dry_run_script() {
let tx_statuses = client.dry_run(&[tx.clone()]).await.unwrap();
let log = tx_statuses
.last()
.expect("Nonempty repsonse")
.expect("Nonempty response")
.result
.receipts();
assert_eq!(3, log.len());
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/tx/utxo_validation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ async fn dry_run_override_utxo_validation() {
.unwrap();
let log = tx_statuses
.last()
.expect("Nonempty reponse")
.expect("Nonempty response")
.result
.receipts();
assert_eq!(2, log.len());
Expand Down