Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

better tap stop #28

Merged
merged 8 commits into from
Jul 14, 2020
Merged

better tap stop #28

merged 8 commits into from
Jul 14, 2020

Conversation

SilentCicero
Copy link
Member

@SilentCicero SilentCicero commented Jul 13, 2020 •
edited
Loading

Changes

  • cleaner tap exit from our own harness
  • less / no new dependancies / updated from environment module
  • just add TAP_EXIT=1 to enable
  • increased malformed block gas limit to 2.3 million from 2 million

@SilentCicero SilentCicero mentioned this pull request Jul 14, 2020
Closed
@adlerjohn adlerjohn mentioned this pull request Jul 14, 2020
Closed
1 task
@adlerjohn adlerjohn linked an issue Jul 14, 2020 that may be closed by this pull request
CI doesn't catch errors #26
Closed
adlerjohn
adlerjohn approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the changes work locally. LGTM.

@adlerjohn adlerjohn merged commit 833fcbd into master Jul 14, 2020
@adlerjohn adlerjohn deleted the silentcicero-develop branch July 14, 2020 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI doesn't catch errors
2 participants
@SilentCicero @adlerjohn