Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade fuel-core to v0.20.1 #1053

Merged
merged 22 commits into from
Aug 8, 2023
Merged

Conversation

xgreenx
Copy link
Contributor

@xgreenx xgreenx commented Jul 18, 2023

This pull request is an upgrade to a fuel-core 0.20.1 release.

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com>
iqdecay
iqdecay previously approved these changes Jul 20, 2023
Copy link
Contributor

@segfault-magnet segfault-magnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the upgrade/fuel-core-v0.20.1 forc build currently fails in the CI. Tried building it locally, same thing.

@xgreenx
Copy link
Contributor Author

xgreenx commented Jul 20, 2023

The pull request doesn't have any changes:) Someone should start work on the upgrade and fix the compilation

@leviathanbeak
Copy link
Contributor

blocked by FuelLabs/sway#4821

@digorithm
Copy link
Member

Should we convert this to draft in the meantime?

@leviathanbeak leviathanbeak marked this pull request as draft July 21, 2023 18:59
# Conflicts:
#	.github/workflows/ci.yml
#	examples/contracts/src/lib.rs
#	packages/fuels/tests/contracts.rs
@xgreenx xgreenx marked this pull request as ready for review August 5, 2023 01:16
@xgreenx xgreenx self-assigned this Aug 6, 2023
Br1ght0ne
Br1ght0ne previously approved these changes Aug 7, 2023
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have some change requests

packages/fuels/tests/providers.rs Outdated Show resolved Hide resolved
examples/contracts/src/lib.rs Outdated Show resolved Hide resolved
Salka1988
Salka1988 previously approved these changes Aug 7, 2023
Copy link
Member

@Salka1988 Salka1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xgreenx xgreenx dismissed stale reviews from Salka1988 and Br1ght0ne via a0f2274 August 7, 2023 12:36
@xgreenx xgreenx requested a review from hal3e August 7, 2023 12:54
examples/contracts/src/lib.rs Outdated Show resolved Hide resolved
examples/contracts/src/lib.rs Outdated Show resolved Hide resolved
packages/fuels/tests/contracts.rs Outdated Show resolved Hide resolved
@hal3e hal3e changed the title An upgrade to fuel-core v0.20.1 feat!: upgrade fuel-core to v0.20.1 Aug 7, 2023
xgreenx and others added 2 commits August 7, 2023 21:20
Co-authored-by: MujkicA <32431923+MujkicA@users.noreply.github.com>
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @xgreenx!

@digorithm digorithm merged commit c64aeca into master Aug 8, 2023
36 checks passed
@digorithm digorithm deleted the upgrade/fuel-core-v0.20.1 branch August 8, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants