Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enum discriminant overflow #1185

Merged
merged 5 commits into from
Nov 6, 2023
Merged

fix: enum discriminant overflow #1185

merged 5 commits into from
Nov 6, 2023

Conversation

Salka1988
Copy link
Member

@Salka1988 Salka1988 commented Nov 2, 2023 •
edited
Loading

Checklist

  • I have linked to any relevant issues.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@Salka1988 Salka1988 added the bug Something isn't working label Nov 2, 2023
@Salka1988 Salka1988 self-assigned this Nov 2, 2023
@Salka1988 Salka1988 linked an issue Nov 2, 2023 that may be closed by this pull request
Support for enums w >= 255 variants. #1178
Closed
hal3e
hal3e requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/fuels-macros/src/derive/utils.rs Outdated Show resolved Hide resolved
@hal3e hal3e changed the title bug: enum discriminant fix fix: enum discriminant overflow Nov 2, 2023
@Salka1988 Salka1988 requested a review from hal3e November 2, 2023 13:06
digorithm
digorithm approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @Salka1988

@Salka1988 Salka1988 merged commit 8062ff6 into master Nov 6, 2023
39 checks passed
@Salka1988 Salka1988 deleted the Salka1988/enums_bug_fix branch November 6, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hal3e hal3e hal3e approved these changes

@MujkicA MujkicA MujkicA approved these changes

@digorithm digorithm digorithm approved these changes

@iqdecay iqdecay Awaiting requested review from iqdecay

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees

@Salka1988 Salka1988

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for enums w >= 255 variants.
4 participants
@Salka1988 @digorithm @MujkicA @hal3e