Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove duplicate function #1243

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

iqdecay
Copy link
Contributor

@iqdecay iqdecay commented Jan 6, 2024

The decode_receipt_return function was a duplicate of the decode function, this PR removes it.

Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Since this is a pub fn we should keep in mind this is a breaking change

@digorithm digorithm changed the title chore: remove duplicate function chore!: remove duplicate function Jan 8, 2024
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@iqdecay iqdecay merged commit 5c734d9 into master Jan 9, 2024
40 checks passed
@iqdecay iqdecay deleted the iqdecay/chore-remove-duplicate-function branch January 9, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants