Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the sdk after the new encoding stabilizes #1318

Closed
hal3e opened this issue Mar 29, 2024 · 0 comments · Fixed by #1338
Closed

Refactor the sdk after the new encoding stabilizes #1318

hal3e opened this issue Mar 29, 2024 · 0 comments · Fixed by #1338
Assignees
@hal3e
Labels
blocked

Comments

@hal3e
Copy link
Contributor

hal3e commented Mar 29, 2024

Once the new encoding stabilizes we can:

  • remove UnresolvedBytes as all data will become inline
  • refactor the function selector code
  • change how we resolve script and predicate data as we do not have to track pointers
  • remove test
@hal3e hal3e added the blocked label Mar 29, 2024
@hal3e hal3e mentioned this issue Mar 29, 2024
Merged
5 tasks
@hal3e hal3e mentioned this issue Apr 18, 2024
Merged
6 tasks
@hal3e hal3e self-assigned this May 3, 2024
hal3e added a commit that referenced this issue May 7, 2024
@hal3e
feat!: remove legacy encoding (#1338)
8df71c3 
closes: #1318

This PR removes all code related to the legacy encoding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hal3e hal3e

Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: remove legacy encoding FuelLabs/fuels-rs
1 participant
@hal3e