Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow assets to be forwarded to contracts on calls #191

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Mar 29, 2022

Previously, contract calls only allowed the default asset to be sent in the call data. This change allows non-default asset ids to be spent when calling a contract.

Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an additional test could be added, otherwise gg for the fix

fuels-abigen-macro/tests/harness.rs Show resolved Hide resolved
@adlerjohn adlerjohn added the bug Something isn't working label Mar 29, 2022
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks for helping out with this one!

fuels-abigen-macro/tests/harness.rs Show resolved Hide resolved
@digorithm digorithm merged commit fc8ac81 into master Mar 29, 2022
@digorithm digorithm deleted the alt-spendables branch March 29, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants