Add fuels-types minimal crate for declaring serializable ABI types. Resolves the cycle between fuels-rs and sway repos.
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By moving these from `sway-types` upstream to the `fuels-rs` repo, we can resolve the remainder of the cyclic dependency between the `sway` and `fuels-rs` repositories. I think semantically it also makes more sense for these VM-specific types to be declared upstream, and for Sway to depend on these rather than vice versa.
Also removes the unused `sway-types` dependency from the `fuels-contract` crate.
mitchmindtree
added
enhancement
mitchmindtree
requested review from
JoshuaBatty,
adlerjohn,
digorithm and
iqdecay
mitchmindtree
changed the title
fuels-rs and sway repos.fuels-types minimal crate for declaring serializable ABI types. Resolves the cycle between fuels-rs and sway repos.
adlerjohn
reviewed
Apr 20, 2022
There was a problem hiding this comment.
Nice, looks like this finally breaks the circular dependency! I'll defer to @digorithm
iqdecay
approved these changes
Apr 20, 2022
digorithm
approved these changes
Apr 20, 2022
mitchmindtree
added a commit
to FuelLabs/sway
that referenced
this pull request
Apr 21, 2022
…s_types` See FuelLabs/fuels-rs#219 for context.
3 tasks
mitchmindtree
added a commit
to FuelLabs/sway
that referenced
this pull request
Apr 21, 2022
…s_types` See FuelLabs/fuels-rs#219 for context.
mitchmindtree
added a commit
to FuelLabs/sway
that referenced
this pull request
May 2, 2022
…s_types` See FuelLabs/fuels-rs#219 for context.
mitchmindtree
added a commit
to FuelLabs/sway
that referenced
this pull request
May 7, 2022
…s_types` See FuelLabs/fuels-rs#219 for context.
mitchmindtree
added a commit
to FuelLabs/sway
that referenced
this pull request
May 7, 2022
…s_types` (#1337) See FuelLabs/fuels-rs#219 for context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
JsonABItype along with the associatedFunctionandPropertytypes fromsway-typesinto a new minimalfuels-typescrate.By moving these from
sway-typesupstream to thefuels-rsrepo, we can resolve the remainder of the cyclic dependency between theswayandfuels-rsrepositories.I think also semantically it makes a little more sense for the Rust representation of these ABI-specific types to be declared under the Rust SDK, and for Sway to depend on these rather than vice versa.
The
fuels-corecrate now depends on these types via the newfuels-typescrate. The unusedsway-utilsdependency has been removed.As an immediate follow-up to
fuels-typeslanding and getting published to crates.io, we should remove these types from thesway-typescrate and instead depend onfuels-typesas necessary throughout theswayrepo.This is one of the blockers for FuelLabs/sway#1321.