Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: decode LOGD data in CallResponse #238

Merged
merged 4 commits into from
Apr 30, 2022
Merged

feat: decode LOGD data in CallResponse #238

merged 4 commits into from
Apr 30, 2022

Conversation

iqdecay
Copy link
Contributor

@iqdecay iqdecay commented Apr 28, 2022

This PR closes #214.

  • feat: decode log data as hex strings in CallResponse property
  • test: add contract for testing logd opcode
  • test: add test for LOGD decoding in harness

@iqdecay iqdecay requested a review from digorithm as a code owner April 28, 2022 17:21
@iqdecay iqdecay self-assigned this Apr 28, 2022
@iqdecay iqdecay requested a review from adlerjohn April 28, 2022 17:22
@iqdecay iqdecay added the enhancement New feature or request label Apr 28, 2022
digorithm
digorithm previously approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

adlerjohn
adlerjohn reviewed Apr 28, 2022
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you add a .gitignore for the new testcase?

@digorithm
Copy link
Member

Oh yeah, good catch. The bin/json wasn't committed, but we should still add the same .gitignore to this new test project.

@iqdecay iqdecay merged commit 7947431 into master Apr 30, 2022
@iqdecay iqdecay deleted the vnepveu/feat-decode-logd-data branch April 30, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

Assignees

@iqdecay iqdecay

Labels
enhancement New feature or request
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for LOGD receipts decoding
3 participants
@iqdecay @digorithm @adlerjohn