Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add Option<Provider> as parameter in run_compiled_script #610

Merged
merged 2 commits into from
Oct 4, 2022
Merged

feat!: add Option<Provider> as parameter in run_compiled_script #610

merged 2 commits into from
Oct 4, 2022

Conversation

Salka1988
Copy link
Member

@Salka1988 Salka1988 commented Oct 4, 2022 •
edited
Loading

I added a new Option<Provider> parameter to the run_compiled_script.

@Salka1988 Salka1988 self-assigned this Oct 4, 2022
@Salka1988 Salka1988 requested a review from a team October 4, 2022 16:10
@Salka1988 Salka1988 linked an issue Oct 4, 2022 that may be closed by this pull request
Duplicated script test helper #608
Closed
@digorithm digorithm changed the title add Option<Provider> as parameter in run_compiled_script feat!: add Option<Provider> as parameter in run_compiled_script Oct 4, 2022
@digorithm digorithm added the enhancement New feature or request label Oct 4, 2022
simonr0204
simonr0204 approved these changes Oct 4, 2022
View reviewed changes
Copy link

@simonr0204 simonr0204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

digorithm
digorithm approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @Salka1988!

@Salka1988 Salka1988 merged commit df2eebe into master Oct 4, 2022
@Salka1988 Salka1988 deleted the Salka1988/add_provider_as_param branch October 4, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonr0204 simonr0204 simonr0204 approved these changes

@digorithm digorithm digorithm approved these changes

@iqdecay iqdecay Awaiting requested review from iqdecay

Assignees

@Salka1988 Salka1988

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicated script test helper
3 participants
@Salka1988 @digorithm @simonr0204