Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: change transfer_to_output to transfer_to_address #614

Merged
merged 5 commits into from
Oct 7, 2022
Merged

Fix: change transfer_to_output to transfer_to_address #614

merged 5 commits into from
Oct 7, 2022

Conversation

digorithm
Copy link
Member

forc 0.25 changed transfer_to_output (the Sway function) to transfer_to_address. This PR makes this change in our test contracts and documentation.

@digorithm digorithm self-assigned this Oct 6, 2022
@digorithm
Copy link
Member Author

digorithm commented Oct 6, 2022 •
edited
Loading

Currently blocked by some breaking behavior in ec_recover_address() introduced recently in forc 0.25. FuelLabs/sway#2962

@MujkicA MujkicA mentioned this pull request Oct 7, 2022
Merged
@digorithm digorithm marked this pull request as ready for review October 7, 2022 18:36
@digorithm digorithm requested a review from a team October 7, 2022 18:36
iqdecay
iqdecay approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

mohammadfawaz
mohammadfawaz approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@mohammadfawaz mohammadfawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@digorithm digorithm merged commit b876558 into master Oct 7, 2022
@digorithm digorithm deleted the rodrigo/transfer-to-address-fix branch October 7, 2022 18:39
@digorithm digorithm removed the blocked label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammadfawaz mohammadfawaz mohammadfawaz approved these changes

@iqdecay iqdecay iqdecay approved these changes

Assignees

@digorithm digorithm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@digorithm @iqdecay @mohammadfawaz