Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update PR template #869

Merged
merged 2 commits into from
Mar 7, 2023
Merged

chore: update PR template #869

merged 2 commits into from
Mar 7, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Mar 6, 2023 •
edited
Loading

This PR adds a checklist to the template.

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@hal3e hal3e requested a review from a team March 6, 2023 10:32
@hal3e hal3e self-assigned this Mar 6, 2023
@hal3e hal3e changed the title chore: update PR temqlate chore: update PR template Mar 6, 2023
Br1ght0ne
Br1ght0ne approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitness is great. LGTM!

digorithm
digorithm approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10

@hal3e hal3e merged commit 8d494a6 into master Mar 7, 2023
@hal3e hal3e deleted the hal3e/update-pr-template branch March 7, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@digorithm digorithm digorithm approved these changes

@iqdecay iqdecay Awaiting requested review from iqdecay

Assignees

@hal3e hal3e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hal3e @digorithm @Br1ght0ne