Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check for unused md files in docs #871

Merged
merged 5 commits into from
Mar 9, 2023
Merged

feat: check for unused md files in docs #871

merged 5 commits into from
Mar 9, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Mar 6, 2023

closes: #767

I have extended our check-docs script which now checks for unused md files in docs/src.

Note: The file docs/src/cookbook/modify-contract-call-tx.md is not used! We have to decide what to do with it.

@hal3e hal3e requested a review from a team March 6, 2023 15:55
@hal3e hal3e self-assigned this Mar 6, 2023
@hal3e hal3e requested review from a team and removed request for a team March 7, 2023 10:20
segfault-magnet
segfault-magnet reviewed Mar 7, 2023
View reviewed changes
scripts/check-docs/src/lib.rs Outdated Show resolved Hide resolved
scripts/check-docs/src/lib.rs Outdated Show resolved Hide resolved
scripts/check-docs/src/lib.rs Outdated Show resolved Hide resolved
scripts/check-docs/src/lib.rs Outdated Show resolved Hide resolved
@hal3e @segfault-magnet
Apply suggestions from code review
8dadd30 
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
@hal3e hal3e requested review from segfault-magnet and a team March 8, 2023 13:24
Salka1988
Salka1988 approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@Salka1988 Salka1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

digorithm
digorithm approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@hal3e hal3e merged commit abfbe8c into master Mar 9, 2023
@hal3e hal3e deleted the hal3e/unused-md-files-book branch March 9, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@Salka1988 Salka1988 Salka1988 approved these changes

@digorithm digorithm digorithm approved these changes

@iqdecay iqdecay Awaiting requested review from iqdecay

Assignees

@hal3e hal3e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a CI step to detect unused .md files in the sdk book.
4 participants
@hal3e @digorithm @Salka1988 @segfault-magnet