chore: default-features warnings on cargo nightly #921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #918
From the cargo book:
We've been inheriting workspace deps and then trying to disable default features. Cargo doesn't support this. If a dep has default features enabled when defined at the workspace level, those features are there to stay. You can only add more to them via
features
or make the dep itself optional in the place you're using it viaoptional=true
.The check for this still hasn't landed in cargo stable. I opted not to add a CI step to build
fuels-rs
with the nightly toolchain to check for regressions in this regard.Functionally nothing has changed. The changes are primarily so we don't mislead ourselves and so we don't run into an error when this does reach stable.
Checklist