Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: default-features warnings on cargo nightly #921

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

segfault-magnet
Copy link
Contributor

closes: #918

From the cargo book:

Other than optional and features, inherited dependencies cannot use any other dependency key (such as version or default-features).

We've been inheriting workspace deps and then trying to disable default features. Cargo doesn't support this. If a dep has default features enabled when defined at the workspace level, those features are there to stay. You can only add more to them via features or make the dep itself optional in the place you're using it via optional=true.

The check for this still hasn't landed in cargo stable. I opted not to add a CI step to build fuels-rs with the nightly toolchain to check for regressions in this regard.

Functionally nothing has changed. The changes are primarily so we don't mislead ourselves and so we don't run into an error when this does reach stable.

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@segfault-magnet segfault-magnet added the tech-debt Improves code quality or safety label Apr 3, 2023
@segfault-magnet segfault-magnet requested a review from a team April 3, 2023 22:36
@segfault-magnet segfault-magnet self-assigned this Apr 3, 2023
Copy link
Member

@Salka1988 Salka1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@segfault-magnet segfault-magnet merged commit 181ef00 into master Apr 5, 2023
@segfault-magnet segfault-magnet deleted the segfault-magnet/feature_warnings branch April 5, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Improves code quality or safety
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default features warnings on nightly
3 participants