Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create message type based on data length #993

Merged
merged 1 commit into from
Jun 8, 2023
Merged

fix: create message type based on data length #993

merged 1 commit into from
Jun 8, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Jun 8, 2023

Create a new message input depending on the message data length.

Checklist

  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@hal3e
fix: create message type based on data length
13bdcb0 
I Please enter the commit message for your changes. Lines starting
@hal3e hal3e added the bug Something isn't working label Jun 8, 2023
@hal3e hal3e self-assigned this Jun 8, 2023
iqdecay
iqdecay approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and clean, lgtm!

Salka1988
Salka1988 approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@Salka1988 Salka1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

digorithm
digorithm approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hal3e hal3e merged commit 2a0b6c5 into master Jun 8, 2023
@hal3e hal3e deleted the hal3e/message-data branch June 8, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iqdecay iqdecay iqdecay approved these changes

@MujkicA MujkicA MujkicA approved these changes

@Salka1988 Salka1988 Salka1988 approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@digorithm digorithm digorithm approved these changes

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

Assignees

@hal3e hal3e

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hal3e @digorithm @Br1ght0ne @Salka1988 @MujkicA @iqdecay