Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a standard way to treat logs. #444

Closed
luizstacio opened this issue Aug 6, 2022 · 3 comments
Closed

Create a standard way to treat logs. #444

luizstacio opened this issue Aug 6, 2022 · 3 comments

Comments

@luizstacio
Copy link
Member

Today on the SDK, we have some places using logger from @ethersproject and others using plain console.log. We should make a standard and fix all places to use the same.

@QuinnLee
Copy link
Contributor

I think we should use logger (or equivalent) over console.log

@camsjams
Copy link
Contributor

I think this can be closed @luizstacio / @Torres-ssf , see:

@arboleya
Copy link
Member

Agreed - closing it.

@luizstacio Please reopen if you think something else is still required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants