Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using FuelError instead of @ethersproject/logger #1278

Merged

Conversation

Torres-ssf
Copy link
Contributor

Using FuelError instead of @ethersproject/logger and removing @ethersproject/logger dependency.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
84.4% (-0.02% 🔻)
5075/6013
🟡 Branches 65.9% 744/1129
🟡 Functions 73.68% 837/1136
🟢 Lines
84.45% (-0.03% 🔻)
4849/5742
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / interface.ts
66.67% (-2.22% 🔻)
50% 76.47%
66.67% (-2.38% 🔻)
🟢
... / abi-coder.ts
94.29% (-0.23% 🔻)
88.89% 87.5%
94.12% (-0.25% 🔻)
🟢
... / resolved-abi-type.ts
98.7% (-0.03% 🔻)
100% 94.74%
98.46% (-0.05% 🔻)
🟡
... / function-fragment.ts
77.01% (-0.77% 🔻)
63.64% 81.82%
79.73% (-0.79% 🔻)
🟡
... / predicate.ts
71.7% (-1.52% 🔻)
53.85% 77.78%
71.7% (-1.52% 🔻)
🔴
... / script-request.ts
20% (-5% 🔻)
0% 0%
20% (-5% 🔻)
🔴
... / revert-error-codes.ts
29.41% (-7.43% 🔻)
0% 0%
31.25% (-7.64% 🔻)

Test suite run success

1207 tests passing in 209 suites.

Report generated by 🧪jest coverage report action from b683b21

@Torres-ssf Torres-ssf enabled auto-merge (squash) September 21, 2023 15:44
@Torres-ssf Torres-ssf merged commit 995401a into master Sep 21, 2023
8 checks passed
@Torres-ssf Torres-ssf deleted the st/refactor/using-fuel-error-instead-of-ethersproject-logger branch September 21, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error handling: what to do with @ethersproject/logger?
3 participants