Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: esm support for keystore package and crypto ops #1049

Merged
merged 18 commits into from
Jul 25, 2023

Conversation

arboleya
Copy link
Member

@arboleya arboleya commented Jun 6, 2023

@arboleya arboleya self-assigned this Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
84.83% (+0.34% 🔼)
4691/5530
🟡 Branches
62.79% (-0.06% 🔻)
626/997
🟡 Functions
69.06% (+0.38% 🔼)
750/1086
🟢 Lines
84.99% (+0.37% 🔼)
4500/5295
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / aes-ctr.ts
100% 100% 100% 100%
🟢
... / randomBytes.ts
100% 100% 100% 100%

Test suite run success

1074 tests passing in 184 suites.

Report generated by 🧪jest coverage report action from 912e57a

@arboleya

This comment was marked as outdated.

@arboleya arboleya marked this pull request as ready for review July 22, 2023 11:05
Copy link
Contributor

@camsjams camsjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

apps/demo-nodejs-esm/package.json Show resolved Hide resolved
@arboleya arboleya enabled auto-merge (squash) July 25, 2023 13:03
@arboleya arboleya merged commit 1b6541b into master Jul 25, 2023
8 of 9 checks passed
@arboleya arboleya deleted the aa/fix/esm-support branch July 25, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keystore package does not work in a Node ESM environment
4 participants