-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix invalid context
imports in doc-examples
#1493
Conversation
This reverts commit 70233c1.
modified: apps/docs-snippets/src/guide/types/std-string.test.ts
Coverage report
Test suite run success1464 tests passing in 258 suites. Report generated by 🧪jest coverage report action from e5cfcad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this.
Just copying my two questions from:
- Don't these
#context
bits defeat the purpose of having unit-tested docs? - Shouldn't these
doc-examples.test.ts
be placed in the doc-snippets?
In short, I think all code-snippets should be placed inside the docs-snippets
package to avoid confusion.
Also, it would be good to have a way to bulletproof the use of #context
to avoid breaking the snippets — is that possible? (cc @Torres-ssf)
@arboleya Since these |
|
Closes #1355