Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction coders #16

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Add transaction coders #16

merged 1 commit into from
Oct 11, 2021

Conversation

AlicanC
Copy link
Contributor

@AlicanC AlicanC commented Oct 6, 2021

This PR adds a new package called "transactions" that contains all types defined in tx_format.md and coders for them.

A few notes:

  • Encoding is memory intensive since all parts are kept in memory before concatenation.
  • Code is a bit ugly because I didn't want to commit to an abstraction at this time. Can be cleaned up later.
  • Tests cover 98% of the code but they aren't that great. They can be improved as we actually start using the code.

Resolves #15

@AlicanC AlicanC requested a review from QuinnLee October 6, 2021 18:59
@AlicanC AlicanC self-assigned this Oct 6, 2021
QuinnLee
QuinnLee previously approved these changes Oct 6, 2021
Copy link
Contributor

@QuinnLee QuinnLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no blockers! there are some lint warnings, but nothing worth blocking the merge

adlerjohn
adlerjohn previously approved these changes Oct 7, 2021
@AlicanC
Copy link
Contributor Author

AlicanC commented Oct 11, 2021

I've just fixed the conflict on tsconfig so I need another approval @QuinnLee, thanks!

@AlicanC AlicanC merged commit 07edd46 into master Oct 11, 2021
@AlicanC AlicanC deleted the transaction-coding branch October 11, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Tx Coding
3 participants