feat: remove uuid dependency in favor of crypto.randomUUID()
#1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10 and
danielbate
as code owners
arboleya
reviewed
Jan 4, 2024
Torres-ssf
requested changes
Jan 4, 2024
There was a problem hiding this comment.
It seems crypto.randomUUID() is only supportable by Node 19.
So if we are going to make this change, we need to require Node >= 19 on the main package.json.
.changeset/new-rats-return.md
Outdated
Comment on lines
1
to
2
| --- | ||
| --- |
There was a problem hiding this comment.
I believe the changeset should not be empty since we are adding a new exportable helper on the crypto package and made changes on the wallet package.
Therefore we want to bump versions on these 2 packages.
There was a problem hiding this comment.
I put crypto into the changeset because of the new export, but didn't put wallet because this is an internal change that doesn't change its functionality at all.
There was a problem hiding this comment.
These packages are published independently.
We can't consider things as "internal" in this way.
The usual is to bump everything that will get a new published version.
After I integrated They also mentioned on the MDN:
|
arboleya
reviewed
Jan 5, 2024
There was a problem hiding this comment.
This looks great! Could you please add some tests?
This crypto package is unique in providing two different builds for node and browser, so the tests are a bit different and may be slightly off, potentially depending on things from:
Just want to say that this package caused problems in the past and needs special attention. I know it directly relates to #1431 and indirectly to #1610.
You can reach out to @Torres-ssf and @danielbate if you need insights.
@Torres-ssf @danielbate @nedsalk Guys, the final aim is to have the crypto package completely unit-tested in the 💯s when testing in both node and browser envs.
I had to put every test into a separate file because putting them into one file caused them to share the same environment and stubbing |
|
Coverage Report:
Changed Files:
|
arboleya
reviewed
Jan 9, 2024
There was a problem hiding this comment.
@nedsalk Having each test on a separate file is a problem. Allowing this to happen in this PR would open the doors for other PRs to do the same. We should invest more time getting to the bottom so this pattern is never introduced in the codebase.
|
Also, if the gain in terms of bundle size will be marginal, we could drop this PR altogether. |
auto-merge was automatically disabled
January 9, 2024 17:31
Pull request was closed
|
@nedsalk Alright. Please remember to remove this PR's mention from: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick win that follows what the
uuidlibrary suggests: