fix: user resolvable errors no longer cause the cli to exit #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… selecting program type
maschad
commented
Apr 5, 2024
maschad
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk and
petertonysmith94
as code owners
maschad
changed the title
maschad
changed the title
Dhaiwat10
previously approved these changes
Apr 5, 2024
arboleya
previously requested changes
Apr 6, 2024
|
I tried to exit out of the CLI but I believe it's stuck in a while loop. May be worth listening to the 
|
|
Something else I noticed (unrelated to your changes), was exiting out at the program types section causes the following error: 
I believe it's due to |
|
Good catch @petertonysmith94 I've made the adjusments. |
Torres-ssf
approved these changes
Apr 9, 2024
maschad
dismissed
arboleya’s stale review
The changes have been resolved, I'm sure @arboleya would approve now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a few painpoints that I picked up when trying to build a demo native asset deployer dApp
Changes
When using
create fuels, there is nothing to indicate how to select which programs I don't / do want so I've enabledinstructionstotrueIn the scenario an error is thrown, the program exits, this is not ideal as this type of error could be resolved if the project is renamed, so I've added a re-try.