Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: fee estimation for multicall #2034

Merged
merged 23 commits into from
Apr 11, 2024
Merged

fix!: fee estimation for multicall #2034

merged 23 commits into from
Apr 11, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Apr 10, 2024 •
edited
Loading

Breaking Changes:

  • Removed unused property usedFee from Provider.getTransactionCost response

@Torres-ssf Torres-ssf added the bug Issue is a bug label Apr 10, 2024
@Torres-ssf Torres-ssf self-assigned this Apr 10, 2024
@fuel-service-user
Copy link
Contributor

fuel-service-user commented Apr 10, 2024 •
edited
Loading

✨ A PR has been created under the rc-2034 tag on fuels-wallet repo.
FuelLabs/fuels-wallet#1234

@arboleya arboleya self-requested a review April 10, 2024 19:13
arboleya
arboleya previously approved these changes Apr 10, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.39%(+0.02%) 69.73%(+0.03%) 77.33%(+0%) 79.54%(+0.02%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/utils/constants.ts 97.43%
(+0.07%)		 100%
(+0%)		 0%
(+0%)		 97.43%
(+0.07%)
🔴 packages/account/src/providers/provider.ts 79.22%
(+0.92%)		 64.74%
(+0.84%)		 85.29%
(+0.22%)		 79.86%
(+0.86%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 85.1%
(-0.51%)		 69.44%
(+0%)		 86%
(-0.27%)		 84.93%
(-0.5%)

@Torres-ssf Torres-ssf enabled auto-merge (squash) April 11, 2024 13:01
maschad
maschad approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!

@Torres-ssf Torres-ssf merged commit 498cffe into master Apr 11, 2024
15 checks passed
@Torres-ssf Torres-ssf deleted the st/fix/tx-total-fee-estimation branch April 11, 2024 15:54
@fuel-service-user fuel-service-user mentioned this pull request Apr 11, 2024
Merged
@nedsalk nedsalk mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix wrong fee estimation for TX on multicall
6 participants
@Torres-ssf @fuel-service-user @arboleya @danielbate @maschad @petertonysmith94