Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runtime errors for ESM distributions #2060

Merged
merged 13 commits into from
Apr 16, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Apr 15, 2024

Relates to #1776

  • Fixes the runtime error reported in the issue.
  • Adds runtime verification to our package distributions.
    (All entrypoints run with node ${entrypoint})

Before

After

@petertonysmith94 petertonysmith94 added the bug Issue is a bug label Apr 15, 2024
@petertonysmith94 petertonysmith94 self-assigned this Apr 15, 2024
Copy link
Contributor

github-actions bot commented Apr 15, 2024

This PR is published in NPM with version 0.0.0-pr-2060-20240415184635

scripts/verify-package-exports.ts Show resolved Hide resolved
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.38%(+0%) 69.67%(+0%) 77.33%(+0%) 79.53%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit 1d92ce7 into master Apr 16, 2024
15 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/bug/fix-runtime-esm branch April 16, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants