-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typegen
generic enums and ./common
import (predicates, scripts)
#2368
fix: typegen
generic enums and ./common
import (predicates, scripts)
#2368
Conversation
typegen
predicates and scripts not importing from ./common
typegen
generic enums and ./common
import for predicates and scripts
typegen
generic enums and ./common
import for predicates and scriptstypegen
generic enums and ./common
import (predicates, scripts)
This comment was marked as outdated.
This comment was marked as outdated.
Coverage Report:
Changed Files:Coverage values did not change👌. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm finding it difficult to validate these changes - do you have a branch for the typegen
work on fuel-gauge
?
It will list out the problematic files. You'll find that the predicates and scripts that have types from Checkout this branch and do the same and it'll be solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Go to
master
,- Run
pnpm pretest --force
,- Run
pnpm tsc --noEmit packages/fuel-gauge/test/typegen/**/*.ts
It will list out the problematic files. You'll find that the predicates and scripts that have types from
common.d.ts
are having errors because the import statement is missing.Checkout this branch and do the same and it'll be solved.
Thanks for that, not sure what was going on there but my typegen
folder wasn't being generated, I believe the --force
fixed the issue.
Nice one 🥇
I found this issue after running
pnpm tsc --noEmit
on typegen outputs of ourfuel-gauge
test suite.