Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typegen enum using specified generic #2370

Merged
merged 3 commits into from
May 22, 2024
Merged

fix: typegen enum using specified generic #2370

merged 3 commits into from
May 22, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented May 22, 2024

I found this issue after running pnpm tsc --noEmit on typegen outputs of our fuel-gauge test suite.

@nedsalk nedsalk added the bug Issue is a bug label May 22, 2024
@nedsalk nedsalk self-assigned this May 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.76%(+0.01%) 70.69%(+0.02%) 76.86%(+0%) 79.85%(+0.01%)
Changed Files:

Coverage values did not change👌.

danielbate
danielbate approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nedsalk 🤝 typegen

@nedsalk nedsalk merged commit 4d65c8c into master May 22, 2024
19 checks passed
@nedsalk nedsalk deleted the ns/fix/typegen-enum-with-specified-generic-field branch May 22, 2024 13:11
@fuel-service-user fuel-service-user mentioned this pull request May 22, 2024
Merged
maschad pushed a commit that referenced this pull request May 23, 2024
@nedsalk @maschad
fix: typegen enum using specified generic (#2370)
2de2c3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@nedsalk nedsalk

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nedsalk @danielbate @petertonysmith94 @Torres-ssf