feat!: pass base asset ID for withdrawals #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ A PR has been created under the |
danielbate
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
nedsalk,
petertonysmith94 and
maschad
as code owners
arboleya
previously approved these changes
May 28, 2024
nedsalk
reviewed
May 28, 2024
packages/account/src/providers/transaction-summary/operations.ts
Outdated
Show resolved
Hide resolved
…hub.com/FuelLabs/fuels-ts into db/feat/replace-asset-id-for-withdrawal
|
Won't be merging this until @LuizAsFight has had a change to review |
…/feat/replace-asset-id-for-withdrawal
petertonysmith94
previously approved these changes
May 28, 2024
Torres-ssf
previously approved these changes
May 28, 2024
nedsalk
previously approved these changes
May 28, 2024
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
danielbate
dismissed stale reviews from Torres-ssf, nedsalk, and petertonysmith94
via
5cc0dad
|
Coverage Report:
Changed Files:
|
petertonysmith94
approved these changes
May 28, 2024
Torres-ssf
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2394
Breaking Changes:
assembleTransactionSummary,getOperationsandgetWithdrawFromFuelOperationsnow all require passing thebaseAssetId