Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add tests to EnumCoder #2515

Merged
merged 11 commits into from
Jun 18, 2024
Merged

chore: add tests to EnumCoder #2515

merged 11 commits into from
Jun 18, 2024

Conversation

mvares
Copy link
Contributor

@mvares mvares commented Jun 13, 2024 •
edited by arboleya
Loading

This PR creates tests to ensure that some validations are validating correctly.

  • Added validation to ensure only one field is provided when encoding enums
  • Added validation to ensure decoded data has the appropriate size

PS: With these tests, we achieved 100% coverage

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@arboleya arboleya added the chore Issue is a chore label Jun 13, 2024
@arboleya arboleya added this to the 0.x mainnet milestone Jun 13, 2024
@mvares mvares changed the title test: add validations to EnumCoder chore: add testss to EnumCoder Jun 13, 2024
@mvares mvares changed the title chore: add testss to EnumCoder chore: add tests to EnumCoder Jun 13, 2024
@mvares
Copy link
Contributor Author

mvares commented Jun 13, 2024

hey @arboleya, could you take a look? The Test/e2e failed

@arboleya arboleya mentioned this pull request Jun 13, 2024
Closed
@danielbate
Copy link
Contributor

danielbate commented Jun 14, 2024 •
edited
Loading

Hey @msensys, thankyou for your contribution :) Please could you sign the CLA?

@danielbate
Copy link
Contributor

#2546 should resolve the problem you currently have in CI

maschad
maschad approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! @msensys

@maschad maschad enabled auto-merge (squash) June 18, 2024 15:01
@maschad maschad merged commit 20f8c89 into FuelLabs:master Jun 18, 2024
20 checks passed
@mvares mvares deleted the m/chore/enum-coder-tests branch June 18, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@maschad maschad maschad approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@mvares mvares

Labels
chore Issue is a chore
Projects
None yet
Milestone
0.x mainnet
Development

Successfully merging this pull request may close these issues.
6 participants
@mvares @CLAassistant @danielbate @maschad @petertonysmith94 @arboleya