Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added docs for isReadOnly function #2564

Merged
merged 5 commits into from
Jun 21, 2024
Merged

fix: added docs for isReadOnly function #2564

merged 5 commits into from
Jun 21, 2024

Conversation

petertonysmith94
Copy link
Contributor

@github-actions github-actions bot added the bug Issue is a bug label Jun 20, 2024
arboleya
arboleya approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@petertonysmith94 petertonysmith94 changed the title fix: is read only for contract fix: added docs for isReadOnly function Jun 20, 2024
@petertonysmith94
Copy link
Contributor Author

Awaiting a response from to verify the resolution of this problem.

@petertonysmith94 petertonysmith94 added this to the 0.x mainnet milestone Jun 20, 2024
danielbate
danielbate approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be related to the issue rather than closing it?

@petertonysmith94
Copy link
Contributor Author

Should this be related to the issue rather than closing it?

I have tested the second point and was unable to replicate the execution issue.
#2564 (review)

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
80.96%(+0%) 72.55%(+0%) 77.98%(+0%) 81.01%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94
Copy link
Contributor Author

  • Type hinted (Fixed)
image
  • Executable via console (not reproducible)
image

@petertonysmith94 petertonysmith94 merged commit 0206568 into master Jun 21, 2024
20 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/fix/is-read-only-for-contract branch June 21, 2024 05:35
@fuel-service-user fuel-service-user mentioned this pull request Jun 21, 2024
Merged
nedsalk pushed a commit that referenced this pull request Jun 27, 2024
@petertonysmith94 @arboleya @nedsalk
fix: added docs for isReadOnly function (#2564)
bec388b 
* chore: added doc block for `isReadOnly` functions

* chore: changeset

---------

Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
@arboleya arboleya mentioned this pull request Jun 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
bug Issue is a bug
Projects
None yet
Milestone
0.x mainnet
Development

Successfully merging this pull request may close these issues.

Method isReadOnly not available in contract
4 participants
@petertonysmith94 @arboleya @danielbate @maschad