-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: forc@0.61.0
upgrade
#2566
Conversation
…els-ts into db/chore/forc-0.61.0
…/chore/forc-0.61.0
I believe all necessary upgrade work has been done, but this work is now blocked due to a |
Could you please link the Sway issue here for easy tracking? |
…/chore/forc-0.61.0
…els-ts into db/chore/forc-0.61.0
@@ -12,7 +12,7 @@ struct Wrapper<T> { | |||
} | |||
|
|||
fn validate_raw_slice(input: raw_slice) { | |||
let vec: Vec<u64> = Vec::from(input); | |||
let vec: Vec<u8> = Vec::from(input); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raw_slice
contains u8
bytes not u64
, so this test needed updating. This was updated initially in #1673 but only now can we compile theraw_slice
in script test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the issue you mentioned, or something else?
Just for clarity, I was referring to a GH issue, but I only found this one for you:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the confusion, this was an internal report. This is now tracked here:
For tracking, this PR is currently blocked by: |
…/chore/forc-0.61.0
…/chore/forc-0.61.0
CI is also currently failing as it is running out of memory, this has also been reported: |
Superseded by #2685 |
forc v0.61.0
#2560str
) in program types #2569This PR:
forc
to0.61.0
str
, coder was introduced already inv1
based on the specstr
in typegen to import the required typeraw_slice
in script test