-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace create-fuels
hardcoded values with constants
#2752
Conversation
@petertonysmith94 I didn't remove the hardcoded values on the faucet page since it's only really a pre-filled default placeholder value for the amount to send and a named constant for it will be overkill in my opinion |
@Dhaiwat10 looks good - do you think it's worth doing the amounts as well? |
Yes I was referring to those values in this comment: #2752 (comment) I don't think it's worth it, as it's just a placeholder value which is pretty self-explanatory via the variable's name and it's never re-used anywhere else |
Coverage Report:
Changed Files:
|
create fuels
remove hardcoded values #2464Checklist
tests
to prove my changesdocs