Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace create-fuels hardcoded values with constants #2752

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Jul 11, 2024

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@Dhaiwat10 Dhaiwat10 added the chore Issue is a chore label Jul 11, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Jul 11, 2024
@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) July 11, 2024 11:46
@Dhaiwat10
Copy link
Member Author

Dhaiwat10 commented Jul 11, 2024

@petertonysmith94 I didn't remove the hardcoded values on the faucet page since it's only really a pre-filled default placeholder value for the amount to send and a named constant for it will be overkill in my opinion

@Dhaiwat10 Dhaiwat10 added this to the 0.x mainnet milestone Jul 11, 2024
@petertonysmith94
Copy link
Contributor

@Dhaiwat10 looks good - do you think it's worth doing the amounts as well?

Hardcoded amounts that we use (ref1 | ref2)

@Dhaiwat10
Copy link
Member Author

Dhaiwat10 commented Jul 11, 2024

Yes I was referring to those values in this comment: #2752 (comment)

I don't think it's worth it, as it's just a placeholder value which is pretty self-explanatory via the variable's name and it's never re-used anywhere else

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.37%(-0.04%) 71.65%(-0.02%) 77.3%(+0.27%) 79.5%(+0.02%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/test-utils/launchNode.ts 98.26%
(-1.74%)
84.74%
(-1.22%)
100%
(+21.43%)
98.34%
(+3.43%)

@Dhaiwat10 Dhaiwat10 merged commit 1b4b033 into master Jul 11, 2024
24 of 25 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/create-fuels-remove-hardcoded-values branch July 11, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create fuels remove hardcoded values
4 participants