Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump react-dom and @types/react-dom #2807

Closed
wants to merge 6 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 21, 2024

Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates react-dom from 18.2.0 to 18.3.1

Release notes

Sourced from react-dom's releases.

18.3.1 (April 26, 2024)

  • Export act from react f1338f

18.3.0 (April 25, 2024)

This release is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19.

Read the React 19 Upgrade Guide for more info.

React

  • Allow writing to this.refs to support string ref codemod 909071
  • Warn for deprecated findDOMNode outside StrictMode c3b283
  • Warn for deprecated test-utils methods d4ea75
  • Warn for deprecated Legacy Context outside StrictMode 415ee0
  • Warn for deprecated string refs outside StrictMode #25383
  • Warn for deprecated defaultProps for function components #25699
  • Warn when spreading key #25697
  • Warn when using act from test-utils d4ea75

React DOM

  • Warn for deprecated unmountComponentAtNode 8a015b
  • Warn for deprecated renderToStaticNodeStream #28874
Changelog

Sourced from react-dom's changelog.

18.3.1 (April 26, 2024)

  • Export act from react f1338f

18.3.0 (April 25, 2024)

This release is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19.

Read the React 19 Upgrade Guide for more info.

React

  • Allow writing to this.refs to support string ref codemod 909071
  • Warn for deprecated findDOMNode outside StrictMode c3b283
  • Warn for deprecated test-utils methods d4ea75
  • Warn for deprecated Legacy Context outside StrictMode 415ee0
  • Warn for deprecated string refs outside StrictMode #25383
  • Warn for deprecated defaultProps for function components #25699
  • Warn when spreading key #25697
  • Warn when using act from test-utils d4ea75

React DOM

  • Warn for deprecated unmountComponentAtNode 8a015b
  • Warn for deprecated renderToStaticNodeStream #28874
Commits
  • d6c42f7 Bump to 18.3.1
  • 8a015b6 Add deprecation warning for unmountComponentAtNode
  • c3b2839 Add deprecation warning for findDOMNode
  • d4ea75d ReactDOMTestUtils deprecation warnings
  • 7548c01 Deprecate renderToStaticNodeStream (#28872) (#28874)
  • 5894232 Enable warning for defaultProps on function components for everyone (#25699)
  • c2a246e Turn on string ref deprecation warning for everybody (not codemoddable) (#25383)
  • 2cfb474 Bump version from 18.2 to 18.3
  • See full diff in compare view
Maintainer changes

This version was pushed to npm by react-bot, a new releaser for react-dom since your current version.


Updates @types/react-dom from 18.2.4 to 18.3.0

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot bot added 2 commits July 21, 2024 20:10
Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together.

Updates `react-dom` from 18.2.0 to 18.3.1
- [Release notes](https://github.com/facebook/react/releases)
- [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/react/commits/v18.3.1/packages/react-dom)

Updates `@types/react-dom` from 18.2.4 to 18.3.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom)

---
updated-dependencies:
- dependency-name: react-dom
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: "@types/react-dom"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielbate Thought this behaviour was disabled? 🤔

@danielbate
Copy link
Contributor

danielbate commented Jul 22, 2024

@petertonysmith94 sorry, what behaviour? Minor prod deps should be individual PRs, but I think it makes exceptions where they have to be grouped.

These dependencies needed to be updated together

@petertonysmith94
Copy link
Contributor

@danielbate After closer inspection it looks it wasn't you - my bad.

I thought the following would ensure that dependabot would only increase based on the package.json:

arboleya
arboleya previously approved these changes Jul 22, 2024
@arboleya arboleya enabled auto-merge (squash) July 22, 2024 19:12
@maschad
Copy link
Member

maschad commented Jul 22, 2024

@danielbate After closer inspection it looks it wasn't you - my bad.

I thought the following would ensure that dependabot would only increase based on the package.json:

You're right @petertonysmith94 this is a strange one as well, because looking at the pnpm.yaml diff I'm not even seeing where react-dom and @types/react-dom were bumped, definitely requires some further digging.

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.4%(+0.04%) 71.53%(-0.12%) 77.32%(+0.02%) 79.53%(+0.04%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/account.ts 82.31%
(+1.16%)
65.07%
(+1.14%)
82.35%
(+0.54%)
82%
(+1.15%)
🔴 packages/account/src/providers/provider.ts 68.02%
(-0.82%)
62.63%
(-1.19%)
73.49%
(-0.31%)
67.98%
(-0.81%)
🔴 packages/account/src/test-utils/launchNode.ts 98.27%
(+0.01%)
85.24%
(+0.5%)
100%
(+0%)
98.36%
(+0.02%)
🔴 packages/contract/src/contract-factory.ts 58.33%
(-0.29%)
46.42%
(+0.27%)
54.54%
(+0%)
58.33%
(-0.29%)
🔴 packages/contract/src/util.ts 93.75%
(+0.42%)
0%
(+0%)
66.66%
(+0%)
88.88%
(+0.65%)
🔴 packages/create-fuels/src/cli.ts 85.5%
(+0.21%)
37.5%
(-2.5%)
100%
(+0%)
85.5%
(+0.21%)

@petertonysmith94
Copy link
Contributor

@danielbate After closer inspection it looks it wasn't you - my bad.
I thought the following would ensure that dependabot would only increase based on the package.json:

You're right @petertonysmith94 this is a strange one as well, because looking at the pnpm.yaml diff I'm not even seeing where react-dom and @types/react-dom were bumped, definitely requires some further digging.

I'm closing this for now - if it becomes a recurring theme then maybe we can dig :)

auto-merge was automatically disabled July 23, 2024 21:02

Pull request was closed

Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 23, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/multi-ec30208de6 branch July 23, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants