fix: allow setting min gas price in launchNode args

[mvares]

• Closes Make launchNode Support Min Gas Price #2813

Summary

In the previous solution, the minGasPrice was already defined by default. This PR fixes it by basing it on the params.

Checklist

• I added — tests to prove my changes
• I updated — all the necessary docs
• I reviewed — the entire PR myself, using the GitHub UI
• I described — all breaking changes and the Migration Guide

Incorrect approval

[Torres-ssf]

@mvares Thanks for this contribution 👍

We are almost there, we only need to remove the --min-gas-price from the informed args.

This is required based on your solution, otherwise the --min-gas-price will still be used twice.

You simply need to edit the call to extractRemainingArgs at the launchNode function.

    const remainingArgs = extractRemainingArgs(args, [
      '--snapshot',
      '--consensus-key',
      '--db-type',
      '--poa-instant',
      '--min-gas-price', // <- needs to be added here
      '--native-executor-version', // Please can you also add this missing flag?
    ]);

[Torres-ssf]

@mvares It would be good if we could also add a test to validate the changes made here.

Let's unskip and change this test case here to:

  it('should ensure estimated fee values on getTransactionCost are never 0', async () => {
    using launched = await setupTestProviderAndWallets({
      nodeOptions: {
        args: ['--min-gas-price', '0'],
      },
    });
    const { provider } = launched;
    const request = new ScriptTransactionRequest();

    const { minFee, maxFee, gasPrice } = await provider.getTransactionCost(request);

    expect(gasPrice.eq(0)).toBeTruthy();

    expect(maxFee.eq(0)).not.toBeTruthy();
    expect(minFee.eq(0)).not.toBeTruthy();
  });

[mvares]

[Torres-ssf]

@mvares This is the last one