Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add vite template to create-fuels #2942

Merged
merged 33 commits into from
Aug 21, 2024
Merged

feat: add vite template to create-fuels #2942

merged 33 commits into from
Aug 21, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Aug 15, 2024 •
edited
Loading

Closes #2838

Release notes

In this release, we:

  • Added a Vite template to create-fuels

Summary

This PR adds a new Vite template to create-fuels, and it will now be the default template.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Dhaiwat10 Dhaiwat10 self-assigned this Aug 15, 2024
@Dhaiwat10 Dhaiwat10 added the feat Issue is a feature label Aug 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024 •
edited
Loading

This PR is published in NPM with version 0.0.0-pr-2942-20240821091416

@Dhaiwat10 Dhaiwat10 marked this pull request as ready for review August 16, 2024 06:22
danielbate
danielbate reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work man 💪🏻

Looks like pretest is failing. Looks like we need to pin some deps, likely related to the lint fail.

templates/vite/vite.config.ts Show resolved Hide resolved
templates/vite/vercel.json Outdated Show resolved Hide resolved
templates/vite/src/routes/faucet.lazy.tsx Outdated Show resolved Hide resolved
templates/vite/src/routeTree.gen.ts Show resolved Hide resolved
templates/vite/package.json Outdated Show resolved Hide resolved
petertonysmith94
petertonysmith94 reviewed Aug 16, 2024
View reviewed changes
templates/vite/src/assets/react.svg Outdated Show resolved Hide resolved
templates/vite/README.md Show resolved Hide resolved
packages/create-fuels/src/cli.ts Outdated Show resolved Hide resolved
templates/vite/eslint.config.js Show resolved Hide resolved
templates/vite/package.json Outdated Show resolved Hide resolved
templates/vite/src/routeTree.gen.ts Show resolved Hide resolved
templates/vite/src/routes/index.lazy.tsx Outdated Show resolved Hide resolved
templates/vite/src/routes/script.lazy.tsx Outdated Show resolved Hide resolved
templates/vite/src/sway-api/contract-ids.json Outdated Show resolved Hide resolved
maschad
maschad reviewed Aug 16, 2024
View reviewed changes
.github/workflows/pr-release.yaml Outdated Show resolved Hide resolved
packages/create-fuels/src/lib/setupProgram.ts Show resolved Hide resolved
templates/vite/gitignore Show resolved Hide resolved
@danielbate
Copy link
Contributor

CI will be resolved after #2990 then this should be good to go.

danielbate
danielbate previously approved these changes Aug 21, 2024
View reviewed changes
@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) August 21, 2024 15:06
nedsalk
nedsalk approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@nedsalk nedsalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through it and didn't find anything I could comment on except some nits on the react code itself, but that was just copied over from the nextjs template so I'll just approve. It's better to have code symmetry in the two templates until we decide the fate of the nextjs template.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.41%(-0.01%) 71.79%(+0%) 77.82%(+0%) 79.54%(-0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/create-fuels/src/cli.ts 87.17%
(+0.16%)		 47.36%
(+0%)		 100%
(+0%)		 87.17%
(+0.16%)

@Dhaiwat10 Dhaiwat10 merged commit c2fa2a5 into master Aug 21, 2024
20 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/create-fuels-vite-template branch August 21, 2024 15:43
@fuel-service-user fuel-service-user mentioned this pull request Aug 21, 2024
Merged
maschad pushed a commit that referenced this pull request Aug 21, 2024
@Dhaiwat10 @danielbate
@rishabhkeshan @maschad
feat: add vite template to create-fuels (#2942)
e5e76ba 
Co-authored-by: Daniel Bate <djbate23@gmail.com>
Co-authored-by: rishabhkeshan <rishabhkeshan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@nedsalk nedsalk nedsalk approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Vite template for create fuels
7 participants
@Dhaiwat10 @danielbate @maschad @petertonysmith94 @nedsalk @Torres-ssf @rishabhkeshan