-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add simpler Option style #471
Conversation
Total Coverage: 89.75% Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment.
packages/contract/src/__test__/coverage-contract/coverage-contract.test.ts
Show resolved
Hide resolved
Total Coverage: 89.75% Coverage Report
|
packages/contract/src/__test__/coverage-contract/coverage-contract.test.ts
Outdated
Show resolved
Hide resolved
packages/abi-coder/src/abi-coder.ts
Outdated
@@ -82,7 +83,9 @@ export default class AbiCoder { | |||
obj[component.name] = this.getCoder(component); | |||
return obj; | |||
}, {}); | |||
return new EnumCoder(enumMatch.name, coders); | |||
return param.type === 'enum Option' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to think of a better way to de-nest this but couldn't. My gut tells me we should refactor getCoder
but probably not a blocker for this pr
Total Coverage: 89.78% Coverage Report
|
Total Coverage: 89.78% Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one code comment.
Co-authored-by: Luiz Estácio | stacio.eth <luizstacio@gmail.com>
Total Coverage: 89.79% Coverage Report
|
Total Coverage: 89.79% Coverage Report
|
Closes #470