fix: remove node.js Buffer for better browser compatibility #656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using on browser env's, Buffer is not available, requiring extra bundler configs with polyfills. Using
stringFromBuffer
from theKeystore
package, it's possible to use Buffer on node env's and TextDecoder on browsers. Fixing the issue.For now, we don't have a CI for automating the tests on browser #284. Because of this, I have tested it locally this are the following steps;
pnpm build
andpnpm link --global --dir .
npx create-react-app my-test-app
my-test-app
runpnpm link --global @fuel-ts/keystore
src/App.js
file, paste the following code right afterimport './App.css'
;Notes: the
/dist
at@fuel-ts/keystore/dist
is only needed because we are usingpnpm link