Fix calling contracts with structs #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlicanC
force-pushed
the
structs-in-contracts
branch
from
e7da468
to
64487ed
Compare
digorithm
approved these changes
Jan 20, 2022
| @@ -258,19 +310,31 @@ export default class Provider { | |||
| request: TransactionRequest; | |||
| wait: () => Promise<TransactionResult & { data: Uint8Array }>; | |||
| }> { | |||
| const dataArray = arrayify(data); | |||
| const functionSelector = dataArray.slice(0, 8); | |||
| const isStructArg = dataArray.slice(8, 16).some((b) => b === 0x01); | |||
There was a problem hiding this comment.
I'm just curious and a bit confused: how come we're confirming it's a struct arg by checking b === 0x01?
There was a problem hiding this comment.
It's an ABI-encoded boolean and we are checking if it has any bytes matching 0x01 in it to see if we should interpret it as true or false.
I was going to make these lines prettier, but I decided to leave a comment instead (and forgot the comment).
I have identified multiple ways to implement this and each one was uglier than the other. Then I realized we only support exactly one argument and when we add support for 0 and 1+ I will have to go over this again. So I just left it like this and will get back to it when it's clear how non-1 args are going to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.