use channel over github api #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
July 15, 2022 10:10
added 10 commits
July 18, 2022 15:33
added 9 commits
July 22, 2022 22:16
There was a problem hiding this comment.
Getting closer! Just a few more nits.
Hmm, I actually discovered a toml parsing bug as a result of #100. I have included the fix in this PR because it was only a one-liner fix (in this commit 1ac5155)
Looking a bit closer at the Settings type, it seems to be doing some manual parsing that might also be better replaced by deriving Deserialize? Probably best addressed in a separate PR either way.
src/download.rs
Outdated
| @@ -298,10 +290,11 @@ pub fn unpack_bins(dir: &Path, dst_dir: &Path) -> Result<Vec<PathBuf>> { | |||
|
|
|||
| #[cfg(test)] | |||
| mod tests { | |||
| use crate::channel::Channel; | |||
|
|
|||
src/channel.rs
Outdated
| @@ -3,21 +3,34 @@ use crate::{ | |||
| download::DownloadCfg, | |||
| }; | |||
| use anyhow::{bail, Result}; | |||
|
|
|||
src/channel.rs
Outdated
| use tempfile::tempdir_in; | ||
| use toml_edit::{Document, Item}; | ||
| use tracing::error; | ||
| use toml_edit::{de, Item}; | ||
|
|
Good point - will create an issue for this |
JoshuaBatty
previously approved these changes
Jul 25, 2022
* fuelup check refactor * Better error handling when splitting and parsing versions * clippy and message changes * revert check logic changes * remove newline
added 2 commits
July 27, 2022 10:26
…bs/fuelup into bingcicle/channel-support
JoshuaBatty
approved these changes
Aug 7, 2022
eightfilms
pushed a commit
that referenced
this pull request
Aug 11, 2022
This reverts commit 557d1e9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87
Note: we might want to wait for #95 to be approved and merged prior to getting this merged
Now that we have channels we should move to using them instead of directly forming URLs within the code itself. This also gets rid of the flakiness issue of getting versions from GitHub API, which fails sometimes as reported here as well.
new
channel.rsto handle all thingsChannelrelated. Eventually we should also supportnightlyandstablehere. There's also a simple test included here to verify correctness of parsing a sample channel (provided withintestsdir)Under this new file there is also the
Packageconstruct which represent a downloadable component and its different distribution info, represented by aHashedBinarywhich contains the respectiveurlandhashbased on the target architecture. Currently we do not check the hash when we download the file but this can be done in a future PR.Introduced new way of creating a
DownloadCfgfrom aPackage. This allowsfuelupto use the download URL directly without having to manually build and format the URL.code changes for existing code has to do with commands
fuelup checkandfuelup toolchain install latest.checkhas been updated to parse the versions from the channel toml, whiletoolchain install latesthas been updated to useDownloadCfg::from_packageto directly download from theurlwithin the correctHashedBinaryrepresentation (depending on your machine)There is also some refactoring of existing code (eg.
get_latest_tag()), mostly to do withdownload.rsto make things smoother when handling both channel usage and github api usage.We do not yet deprecate GitHub API support completely for at least a few versions to ensure stability, so we keep them as a fallback for now.