Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current latest channel as stable channel instead #117

Closed
wants to merge 13 commits into from

Conversation

eightfilms
Copy link
Contributor

Closes #116

My observation of the needs of both internal and external devs seem to suggest that it might be better to always provide the latest binaries regardless of whether they passed tests.

It also makes sense to name the releases that passed integration tests as compatible and therefore stable, since they have basically passed all known success and failure tests. Until we have a better definition of what constitutes a stable toolchain, I propose we use this definition in the meantime.

The recent PR that defines the latest toolchain #95 will be used as the stable toolchain instead while the latest toolchain will always provide the latest binaries, regardless of whether they passed integration tests.

To accomplish this,

  • I brought back parts of the old index-versions.sh that indexes latest versions indiscriminately as a separate index-versions-latest.yml workflow to publish the latest channel. This also runs every 30 minutes.
  • I made necessary changes to the existing workflow(s) that publishes the latest channel, to publish the stable channel instead. This is done through changes to names of jobs, files, etc. within the YAML configuration files.
  • Updated docs (CHANNELS.md). This should eventually be within an mdbook.

@eightfilms eightfilms added ci new feature New feature labels Jul 25, 2022
@eightfilms eightfilms requested review from mitchmindtree and a team July 25, 2022 12:39
@eightfilms eightfilms self-assigned this Jul 25, 2022
@eightfilms
Copy link
Contributor Author

Closing this PR after a discussion with @mitchmindtree.

fuelup's mission should be to provide tested and reliable toolchains, so therefore we shouldn't need a separately latest toolchain that purely has the latest binaries since they might fail integration tests with each other. Any more cutting edge than latest should mean either building from source or using custom toolchains (soon ™️)

If we use the mission as guidance for fuelup's development, the changes this PR make would be a regression.

@eightfilms eightfilms closed this Jul 26, 2022
@eightfilms eightfilms deleted the bingcicle/updated-latest-workflow branch August 15, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re-define and re-implement latest channel
1 participant